jwonders commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351738004 @jkosh44 I'm interested in looking at it. I probably can't get to it until this weekend rthough. Hopefully the `AsyncCommitResult` doesn't need to pass much intermediate information between steps. There is probably a balance between doing everything in-line with `thenCompose(...)` and keeping some of the current structure to make the short-circuiting cleaner and allow for capturing data in the surrounding scope. The direction I would approach this from was starting with the same structure, introducing `thenCompose(...)` and then trying to refactor to achieve the understandability @keith-turner is looking for.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
