keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-352465141 > In terms of exception handling for CommitStep, I thin we can append compose with .exceptionally(e -> getFailureOp(cd)) or use handleAsync like addCallback above it. I think either of those approaches would work. However I am still not very familiar with `.exceptionally()`, so its hard for me to make a call on it. I need to experiment with it and get some hands on experience. > For all the TODOs saying something along the lines of "do async" what do you think about just surrounding them with CompletableFuture.runAsync()`? I think that would work in some cases. If you think the approach I proposed is good, feel free to copy it or branch it. One thing I realized about this approach is that it makes the normal path easy to follow in the code. However the error path is still spread out in the code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
