keith-turner commented on a change in pull request #987: Possible misleading
calculation of notifications size in the queue is fixed.
URL: https://github.com/apache/fluo/pull/987#discussion_r158562258
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/worker/NotificationProcessor.java
##########
@@ -77,8 +77,8 @@ public Integer getValue() {
private long size(RowColumn rowCol) {
Column col = rowCol.getColumn();
- return rowCol.getRow().length() + col.getFamily().length() +
col.getQualifier().length()
- + col.getVisibility().length();
+ return (long) rowCol.getRow().length() + col.getFamily().length()
Review comment:
Will this make the expression be evaluated as a long? Was it being
evaluated as an int before and then converted to long at the end?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
