ctubbsii commented on a change in pull request #995: fixes #890
URL: https://github.com/apache/fluo/pull/995#discussion_r159134646
##########
File path: modules/core/pom.xml
##########
@@ -141,6 +141,33 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <minimizeJar>true</minimizeJar>
+ <artifactSet>
+ <includes>
+ <include>org.apache.thrift:libthrift</include>
Review comment:
Perhaps the original issue should have been more specific, but the intent
was to [relocate][1] the libthrift classes. If we don't do the relocation, then
the original conflict with Accumulo's libthrift dependency will not be resolved.
[1]:
https://maven.apache.org/plugins/maven-shade-plugin/examples/class-relocation.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
