kpm1985 commented on issue #995: fixes #890 URL: https://github.com/apache/fluo/pull/995#issuecomment-354870822 @mikewalch nice eye catching the lysdexic mistakes lately, glad I'm not the only one now! On Jan 2, 2018 9:10 AM, "Keith Turner" <[email protected]> wrote: > *@keith-turner* commented on this pull request. > ------------------------------ > > In modules/core/pom.xml > <https://github.com/apache/fluo/pull/995#discussion_r159270029>: > > > + <artifactId>maven-shade-plugin</artifactId> > + <executions> > + <execution> > + <goals> > + <goal>shade</goal> > + </goals> > + <phase>package</phase> > + <configuration> > + <minimizeJar>true</minimizeJar> > + <artifactSet> > + <includes> > + <include>org.apache.thrift:libthrift</include> > + </includes> > + </artifactSet> > + <shadedArtifactAttached>true</shadedArtifactAttached> > + <shadedClassifierName>shaded</shadedClassifierName> > > I also think it would be best to modify the original jar instead of create > a separate shaded jar. > > ? > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/fluo/pull/995#discussion_r159270029>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/Acg-LMGxpkaots9siyyHv8X6QZgmx-Xkks5tGmLvgaJpZM4RPyG3> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
