keith-turner commented on a change in pull request #999: Create 'fluo remove'
command #991
URL: https://github.com/apache/fluo/pull/999#discussion_r161257910
##########
File path: modules/api/src/main/java/org/apache/fluo/api/client/FluoAdmin.java
##########
@@ -119,6 +119,15 @@ public TableExistsException() {
void initialize(InitializationOptions opts)
throws AlreadyInitializedException, TableExistsException;
+ /**
+ * Removes Fluo application, Accumulo table and shared configuration in
Zookeeper. Shared configuration
+ * consists of all properties except those with
+ * {@value org.apache.fluo.api.config.FluoConfiguration#CONNECTION_PREFIX}
prefix.
+ *
+ * @since 1.2.0
+ */
+ void remove();
Review comment:
> An integration test is a great idea but should probably be a separate
issue.
Creating the test in a follow on PR is ok with me.
> I've notice we don't have many references (tests) on command module.
That's right, we do not have any automated test for the commands other than
things like [stresso](https://github.com/astralway/stresso) that use them in
scripts, but that does not cover all commands and options. However the
`remove()` call is in the Java API making it a bit easier to test in an IT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
