keith-turner commented on a change in pull request #1001: [WIP] - Issue 978
URL: https://github.com/apache/fluo/pull/1001#discussion_r162711989
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/impl/TransactionImpl.java
##########
@@ -134,10 +136,6 @@ private static boolean isReadLock(Bytes val) {
private TxStatus status = TxStatus.OPEN;
private boolean commitAttempted = false;
- // for testing
- private boolean stopAfterPreCommit = false;
Review comment:
@jkosh44 I really like the way you refactored the code to remove these. I
wasn't sure of the best way to handle these when I was looking at this from a
high level. The way in which you dispensed with these unsightly booleans by
executing a subset of the steps is quite elegant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
