keith-turner commented on issue #995: fixes #980 URL: https://github.com/apache/fluo/pull/995#issuecomment-361683012 This seems to be working well. I installed the fluo jars locally and was able to do the following. * Ran mvn dependency:tree on stresso and did not see thrift as a dep of fluo core * Used javap to inspeact a fluo class that uses thrift ``` $ javap -cp ~/.m2/repository/org/apache/fluo/fluo-core/1.2.0-SNAPSHOT/fluo-core-1.2.0-SNAPSHOT.jar -p org.apache.fluo.core.oracle.OracleServer | grep shaded.thrift private org.apache.fluo.core.shaded.thrift.server.THsHaServer server; public org.apache.fluo.core.thrift.Stamps getTimestamps(java.lang.String, int) throws org.apache.fluo.core.shaded.thrift.TException; private synchronized long getTimestampsImpl(java.lang.String, int) throws org.apache.fluo.core.shaded.thrift.TException; public boolean isLeader() throws org.apache.fluo.core.shaded.thrift.TException; private java.net.InetSocketAddress startServer() throws org.apache.fluo.core.shaded.thrift.transport.TTransportException; static org.apache.fluo.core.shaded.thrift.server.THsHaServer access$600(org.apache.fluo.core.oracle.OracleServer); ``` * Used `jar -tf` to list files in fluo core jar and saw the shaded and relocated thrift jars * Successfully ran `mvn verify` on stresso (against Accumulo 1.7 and 1.8) using jars created by this PR. @ctubbsii do you think this is ready to merge?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
