keith-turner commented on a change in pull request #1013: Making changes in the 
file according to issue 1011
URL: https://github.com/apache/fluo/pull/1013#discussion_r167674387
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/fluo/core/async/SyncCommitObserver.java
 ##########
 @@ -28,33 +30,44 @@
   private volatile boolean aacked = false;
   private volatile Exception error = null;
   private volatile String commitFailMsg = "";
+  private static AtomicBoolean isMethodCalled = new AtomicBoolean(false);
 
 Review comment:
   One really good thing came out of this being static.  While debugging it, I 
discovered that the async commit code could eat exceptions.  I opened #1014 to 
fix this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to