alanblueshift commented on a change in pull request #1018: Scan command now can 
produce results as csv and json. Related to #984
URL: https://github.com/apache/fluo/pull/1018#discussion_r169991318
 
 

 ##########
 File path: 
modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.java
 ##########
 @@ -935,6 +938,18 @@ public SimpleConfiguration getAppConfiguration() {
     return subset(APP_PREFIX);
   }
 
+  /**
+   * @return A subset of this configuration using the prefix {@value 
#SCAN_PREFIX}. Any change made
+   *         to subset will be reflected in this configuration, but with the 
prefix added. This
+   *         method is useful for setting application configuration before 
initialization. For
+   *         reading application configuration after initialization, see
+   *         {@link FluoClient#getAppConfiguration()} and {@link 
Context#getAppConfiguration()}
+   * @since 1.2
+   */
+  public SimpleConfiguration getScanConfiguration() {
 
 Review comment:
   I don't think so. I just think this could be convenient. 
   But you are right. I'll remove this implementation.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to