mikewalch commented on a change in pull request #1018: Scan command now can
produce results as csv and json. Related to #984
URL: https://github.com/apache/fluo/pull/1018#discussion_r170313795
##########
File path:
modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.java
##########
@@ -935,6 +938,18 @@ public SimpleConfiguration getAppConfiguration() {
return subset(APP_PREFIX);
}
+ /**
+ * @return A subset of this configuration using the prefix {@value
#SCAN_PREFIX}. Any change made
+ * to subset will be reflected in this configuration, but with the
prefix added. This
+ * method is useful for setting application configuration before
initialization. For
+ * reading application configuration after initialization, see
+ * {@link FluoClient#getAppConfiguration()} and {@link
Context#getAppConfiguration()}
+ * @since 1.2
+ */
+ public SimpleConfiguration getScanConfiguration() {
Review comment:
I am OK with the configuration options but I agree with that they shouldn't
be in FluoConfiguration or `fluo-app.properties`. I think all configuration in
`fluo-app.properties` will get loaded to Zookeeper and setting them would
affect everyone that runs the `fluo scan` command for that application from
anywhere on the cluster. Maybe the `fluo scan` could have an command line
option for a path to a properties file where this configuration could be
specified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
