ctubbsii commented on a change in pull request #1032: fixes #1026 enable
scanning notifications
URL: https://github.com/apache/fluo/pull/1032#discussion_r183187650
##########
File path:
modules/cluster/src/main/java/org/apache/fluo/cluster/runner/AppRunner.java
##########
@@ -234,7 +234,7 @@ public String getRowPrefix() {
public ScanUtil.ScanOpts getScanOpts() {
return new ScanUtil.ScanOpts(startRow, endRow, columns, exactRow,
rowPrefix, help,
- hexEncNonAscii, scanAccumuloTable, false);
+ hexEncNonAscii, scanAccumuloTable, false, false);
Review comment:
boolean arguments like this are kind of a bad idea; should probably use
enums. have no idea what these booleans represent at a glance, and multiple
sequential params of the same time are prone to bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
