ctubbsii commented on a change in pull request #1035: Fluo 1000
URL: https://github.com/apache/fluo/pull/1035#discussion_r192226635
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
##########
@@ -412,17 +418,23 @@ public void takeLeadership(CuratorFramework
curatorFramework) throws Exception {
synchronized (this) {
byte[] d = curatorFramework.getData().forPath(maxTsPath);
currentTs = maxTs = LongUtil.fromByteArray(d);
+
+ isLeader = true;
}
gcTsTracker = new GcTimestampTracker();
gcTsTracker.start();
- isLeader = true;
-
while (started) {
// if leadership is lost, then curator will interrupt the thread that
called this method
Thread.sleep(100);
}
+ } catch (IllegalStateException e) {
Review comment:
The `LeaderSelector` appears to be swallowing this, rather than throwing it,
so I don't think there's any catch we can do in our code to handle this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
