cjmctague commented on a change in pull request #1040: Replace anonymous types
with lambda
URL: https://github.com/apache/fluo/pull/1040#discussion_r194851399
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
##########
@@ -299,13 +299,7 @@ private InetSocketAddress startServer() throws
TTransportException {
serverArgs.outputProtocolFactory(new TCompactProtocol.Factory());
server = new THsHaServer(serverArgs);
- Runnable st = new Runnable() {
-
- @Override
- public void run() {
- server.serve();
- }
- };
+ Runnable st = () -> server.serve();
Review comment:
I don't see why not.
Also I left this one since the class is Deprecated. Is that the right
approach?
https://github.com/apache/fluo/blob/327ab36c194a73343bcf38b8578b83647979266a/modules/cluster/src/main/java/org/apache/fluo/cluster/runner/AppRunner.java#L160-L166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
