kpm1985 commented on a change in pull request #1043: FLUO-1002 Create
integration test for `FluoAdmin.remove()`
URL: https://github.com/apache/fluo/pull/1043#discussion_r196614704
##########
File path:
modules/integration/src/test/java/org/apache/fluo/integration/client/FluoAdminImplIT.java
##########
@@ -184,4 +193,90 @@ public void testInitializeLongChroot() throws Exception {
}
}
+
+ @Test
+ public void testRemove() throws Exception {
+
+
+ // oserver is started before every test so oserver is running
+ try (FluoAdmin admin = new FluoAdminImpl(config)) {
+ admin.remove();
+ fail("expected remove() to fail with oracle server running");
+ } catch (FluoException e) {
+ }
+
+ // TODO assert null or something below instead of sys.out
Review comment:
Absolutely, I wast to use asserts and kill the sys.out statements I left
from debugging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
