keith-turner commented on a change in pull request #1043: FLUO-1002 Create
integration test for `FluoAdmin.remove()`
URL: https://github.com/apache/fluo/pull/1043#discussion_r201010589
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
##########
@@ -211,6 +212,10 @@ public void remove() {
"The Zookeeper connection string (set by 'fluo.connection.zookeepers')
"
+ " must have a chroot suffix.");
+ if (OracleServerUtils.oracleExists(getAppCurator())) {
Review comment:
This is a very nice check. Could drop `You` from error message `Must stop
the oracle server to remove an application`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
