ctubbsii commented on a change in pull request #187: fixes #185 No longer write to stdin URL: https://github.com/apache/fluo-uno/pull/187#discussion_r204529974
########## File path: bin/impl/setup-metrics.sh ########## @@ -94,14 +94,14 @@ $SED "/fluo.metrics.reporter.graphite/d" "$FLUO_PROPS" echo "fluo.metrics.reporter.graphite.frequency=30" } >> "$FLUO_PROPS" -echo >&0 "Configuring InfluxDB..." +print_to_console "Configuring InfluxDB..." Review comment: These are fine, but one advantage of using the entire arg array rather than `$1` is that these quotes are no longer needed. It's not necessary to remove them, but it's nice to have the option to avoid quotes, in case we run into situations where we have to escape quotes in crazy ways. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
