keith-turner commented on issue #1003: Refactor remove and init apis to check if running URL: https://github.com/apache/fluo/issues/1003#issuecomment-427083147 > Is there a particular reason you suggested using FluoExceptions and not AlreadyInitializedExceptions? No, I would be in favor of using AlreadyInitializedException when appropriate. I think the main thing I was thinking about was not calling System.exit. Its ok for command to call System.exit, but API impls should not. > What is the reason for the nested try blocks in the remove and init Fluo Commands? I do not know of a reason to keep these. Seems like the catch could be moved to the surrounding try. > However it will only do this if there isn't an application already running? Yeah, the update should not happen if the app is running.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
