keith-turner commented on a change in pull request #1052: Issue 1003 - Refactor
remove and init apis to check if running
URL: https://github.com/apache/fluo/pull/1052#discussion_r222991078
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
##########
@@ -203,7 +212,12 @@ public void initialize(InitializationOptions opts)
}
@Override
- public void remove() {
+ public void remove() throws AlreadyInitializedException {
+ if (applicationRunning()) {
+ throw new AlreadyInitializedException(
Review comment:
I feel like this exception should only be thrown by the init function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
