kpm1985 commented on a change in pull request #8: Initial PageLoader Test
ClassInitial test for the PageLoader class that covers null and empty checks
URL: https://github.com/apache/fluo-examples/pull/8#discussion_r266178383
##########
File path:
webindex/modules/data/src/test/java/webindex/data/fluo/PageLoaderTest.java
##########
@@ -0,0 +1,63 @@
+package webindex.data.fluo;
+
+import java.net.MalformedURLException;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import webindex.core.models.Page;
+import webindex.core.models.URL;
+
+@SuppressWarnings("unused")
+public class PageLoaderTest {
+
+ @Test
+ public void testUpdatePageWithNullPage() {
+ Page p = null;
+ PageLoader loader = PageLoader.updatePage(p);
+ loader = null;
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void testEmptyPageThrowsIllegalArgument() {
+ Page p = Page.EMPTY;
+ PageLoader loader = PageLoader.updatePage(p);
+ loader = null;
+ }
+
+ @Test(expected = NullPointerException.class)
+ public void testDeleteFailsWithNullUrl() {
+ try {
+ PageLoader loader = PageLoader.deletePage(null);
+ } catch (MalformedURLException e) {
Review comment:
Not sure if this is correct but did a simple refactor where it catches
Exception e and test if its an instance of a NPE and if yes throws NPE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
