ctubbsii commented on a change in pull request #1074: Update Fluo to build
against Accumulo 2.0.0 RC2
URL: https://github.com/apache/fluo/pull/1074#discussion_r311244199
##########
File path: pom.xml
##########
@@ -254,27 +254,13 @@
</dependency>
</dependencies>
</dependencyManagement>
- <pluginRepositories>
- <!--
- needed for accumulo-maven-plugin SNAPSHOT version
- see PR apache/maven-apache-parent#1
- -->
- <pluginRepository>
- <releases>
- <enabled>false</enabled>
- </releases>
- <id>apache.snapshots</id>
- <name>Apache Snapshot Repository</name>
- <url>https://repository.apache.org/snapshots</url>
- </pluginRepository>
- </pluginRepositories>
Review comment:
> Personally I dislike when the build pulls down some random snapshot
version. Would it make sense to put this in a profile?
It's not entirely random. Maven does try to resolve the most recent
snapshot. But, I get your point. That behavior, however, is already established
for non-plugins in the Apache parent POM.
It doesn't matter to me if we remove this, since we don't currently need it.
I would just get annoyed re-adding it if we needed it again in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
