keith-turner commented on a change in pull request #270: Support Accumulo 
installs on Microsoft Azure
URL: https://github.com/apache/fluo-muchos/pull/270#discussion_r312954270
 
 

 ##########
 File path: conf/muchos.props.example.azure
 ##########
 @@ -0,0 +1,180 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   The example files need to be merged in some way because having two with lots 
of duplicate information will be a maintenance burden going forward.  The files 
will likely diverge.  I can think of at least two solutions.
   
    * Merge both files (EC2 and Azure) into one.
    * Have three files muchos-common.props, muchos-ec2.props, and 
muchos-azure.props.
   
   This should probably be a follow on PR/issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to