srajtiwari commented on a change in pull request #270: Support Accumulo installs on Microsoft Azure URL: https://github.com/apache/fluo-muchos/pull/270#discussion_r313158983
########## File path: ansible/roles/azure/tasks/create_vmss.yml ########## @@ -0,0 +1,238 @@ +--- + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + Review comment: @keith-turner that's correct. The code in the file is basically the equivalent of what the existing code is doing with boto3. One addition from our side is that we are giving users the option to create a separate VM to use as proxy host instead of using the first node in the cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
