ctubbsii commented on a change in pull request #281: Execute the start Accumulo
2.0 tservers task with nohup
URL: https://github.com/apache/fluo-muchos/pull/281#discussion_r326367856
##########
File path: ansible/accumulo.yml
##########
@@ -37,14 +37,14 @@
- hosts: workers
tasks:
- name: "start accumulo 2.0 tablet servers"
- command: "{{ accumulo_home }}/bin/accumulo-service tserver start"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service tserver start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
when: accumulo_major_version == '2'
- hosts: accumulomaster
tasks:
- name: "start accumulo 2.0 master, monitor, gc & tracer"
- command: "{{ accumulo_home }}/bin/accumulo-service {{ item }} start"
+ command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }}
start"
register: start_result
changed_when: "'Starting' in start_result.stdout"
Review comment:
I think you're right about that. The "Starting" message occurs prior to
actually executing the java process (which is already executed with `nohup`).
But I still think this is probably the right fix, since the alternative is to
add a "Started" message in the `accumulo-service` script and to watch that
instead, which could be misleading if the java process failed to start.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
