sputnik13 commented on issue #285: refactor infrastructure specific python and ansible to separate packages/roles URL: https://github.com/apache/fluo-muchos/issues/285#issuecomment-533608488 Short answer, reorganzing in ansible, and refactoring in python, all for the sake of better strucutre. For the ansible changes I'm thinking there ought to be a separate cloud/infrastructure specific role. "common" seems like it's something that should be common to all nodes regardless of infrastructure, so it's more about just reorganizing. For config.py, I'm thinking there should be a separation of configs for each deployment type. Currently there are accessors for certain general values in config.py, no accessors configs from other sections and a number of methods that are checking "cluster_type" to make provide different behaviors depending on what the target environment is. So I'm thinking it will make more sense to have a base config class with accessors for the shared sections and target specific sub-classes to allow accessors to their own sections as well as differentiated behavior for common methods like verify_*.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
