ctubbsii commented on a change in pull request #1078: Updated Fluo to build and
run with Java 11
URL: https://github.com/apache/fluo/pull/1078#discussion_r337207491
##########
File path: pom.xml
##########
@@ -57,31 +56,26 @@
<accumulo.version>2.0.0</accumulo.version>
<curator.version>4.0.1</curator.version>
<dropwizard.version>0.8.1</dropwizard.version>
- <findbugs.maxRank>11</findbugs.maxRank>
+ <!-- Prevent findbugs from runnning because it does not work with Java 11
and is configured to run by parent pom. Spotbugs is configured in place of
findbugs. -->
+ <findbugs.skip>true</findbugs.skip>
<hadoop.version>3.1.1</hadoop.version>
- <logback.version>1.2.3</logback.version>
<releaseProfiles>fluo-release</releaseProfiles>
<slf4j.version>1.7.12</slf4j.version>
- <twill.version>0.13.0</twill.version>
+ <spotbugs.version>3.1.12</spotbugs.version>
<zookeeper.version>3.4.8</zookeeper.version>
</properties>
<dependencyManagement>
<dependencies>
- <dependency>
- <groupId>ch.qos.logback</groupId>
- <artifactId>logback-classic</artifactId>
- <version>${logback.version}</version>
- </dependency>
- <dependency>
- <groupId>ch.qos.logback</groupId>
- <artifactId>logback-core</artifactId>
- <version>${logback.version}</version>
- </dependency>
<dependency>
<groupId>com.beust</groupId>
<artifactId>jcommander</artifactId>
<version>1.72</version>
</dependency>
+ <dependency>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-annotations</artifactId>
+ <version>${spotbugs.version}</version>
+ </dependency>
Review comment:
I don't think you're using this, but might be useful to make use of it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
