arvindshmicrosoft commented on a change in pull request #294: Fix Muchos to
work with Java 11
URL: https://github.com/apache/fluo-muchos/pull/294#discussion_r339270569
##########
File path: lib/muchos/config.py
##########
@@ -65,6 +65,11 @@ def verify_config(self, action):
if not self.has_service(service):
exit("ERROR - Missing '{0}' service from [nodes]
section of muchos.props".format(service))
+ # validate if we are using Java 11 and fail if we are using
Accumulo 1.x
+ # See https://github.com/apache/accumulo/issues/958 for details
+ if self.java_product_version() == 11 and
self.version('accumulo').split('.')[0] == '1':
+ exit("ERROR - Java 11 is not supported with Accumulo version
'{0}'".format(self.version('accumulo')))
Review comment:
@keith-turner I checked and looks like you have already
[fixed](https://github.com/apache/accumulo/commit/9591cc2b4b00897894e498d7a4cf49d63edbe7fc)
this in 1.9 master. I presume that fix will make it to 1.9.4 so on the Muchos
side, I will revise my check to specifically check for 1.9.3 or less and then
block if Java 11 (or higher) is in use.
Again, please hold off on merging this till I make those validations real.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
