jkosh44 commented on issue #983: Stop using system.exit for fluo commands URL: https://github.com/apache/fluo/issues/983#issuecomment-563474861 I've been looking through the command code and I have a couple of questions/comments for anyone that may have worked on the code and knows the answer. - Some of the commands currently seem to end by returning or letting exceptions propagate to main, while others explicitly call System.exit. I'm wondering if this was an intentional decision or just the result of multiple developers working on it at different times? - Some commands use a Logger while others print directly to System.out and System.err. I'm also wondering if this was an intentional decision or just the result of multiple developers working on it at different times? - On a similar subject to the last point, I think some thought needs to go into Logger vs System.out/System.err. If the command is being called by a UI or API then we probably want to log to a Logger. However if it's being called by the CLI then we probably want to log to System.out/System.err. How do we make this determination? I haven't really given this much thought yet. Might be something to consider as part of a separate issue/PR. - There doesn't seem to be a lot of tests in the command module. I may try and add some as part of this issue depending on the complexity. I'm thinking most meaningful tests will have to be integration tests though.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
