jkosh44 opened a new pull request #1083: [WIP] POC for Command module with 
centralized Command Pattern logic
URL: https://github.com/apache/fluo/pull/1083
 
 
   This is my first pass attempt at a POC for using the command pattern to 
implement the Fluo command module. It still needs some polishing up and I want 
to add tests but I wanted to give people a chance to review and comment before 
continuing on. It doesn't conform to the command pattern 100% but it's pretty 
close, and I found forcing it to conform 100% was either making it too verbose 
or unnecessarily complicated.
   
   This ended up touching just about every file in the command module and 
became a decently big change. 
   
   I didn't attempt to solve the System.out/System.err vs Logger problem as I 
described in Issue #983  but it may be something to consider while reviewing.
   
   The overall goal of this PR is to make it easier to reuse the commands 
outside of the command line (in a UI or API for example) while moving the logic 
to run them from the command line to a central location.
   
   Fixes #983 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to