jkosh44 commented on a change in pull request #1083: [WIP] POC for Command
module with centralized Command Pattern logic
URL: https://github.com/apache/fluo/pull/1083#discussion_r357931162
##########
File path: modules/command/src/main/java/org/apache/fluo/command/FluoExec.java
##########
@@ -44,25 +50,39 @@ protected void configure() {
}
}
- public static void main(String[] args) throws Exception {
- if (args.length < 2) {
- System.err.println("Usage: fluo exec <app> <class> args...");
- System.exit(-1);
+ @Parameter(description = "<app> <class> args...", variableArity = true)
Review comment:
Another quick note about this class, unlike the other commands it parses out
the application name by position not by the -a option. Also it does not have a
-o option for overriding configuration. It makes it slightly harder to reuse
functionality and slightly breaks the consistency of the other commands. May
not be something we address in this PR, but just wanted to throw that out there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
