jkosh44 commented on issue #1083: [WIP] POC for Command module with centralized Command Pattern logic URL: https://github.com/apache/fluo/pull/1083#issuecomment-566860671 So I'm pretty happy with the current status of this PR and I think I've addressed all the comments. If I've missed any or if there are other issues please let me know. I'm going to work on adding tests and doing some functional testing. It might take a little while because I need to figure out the best way to test all the commands. There's a couple of potential follow up issues though that I've come across 1. Investigate possible ways of condensing the [fluo script](https://github.com/apache/fluo/pull/1083/files#diff-9085d61b756f1527aae51ea144142951). After this change the [fluo script](https://github.com/apache/fluo/pull/1083/files#diff-9085d61b756f1527aae51ea144142951) has become pretty repetitive, there may be some ways of condensing it. 2. Figure out solution for printing to logger vs `System.out`. Some commands print to `System.out` while others log to a Logger 3. Make commands more friendly to be used outside of CLI. (This may be very related to number 2). Because `execute` returns `void`, the caller doesn't get much information from the commands, just whether it was successful or if there was an Exception. For example `FluoList` is pretty useless outside of the CLI right now, it just prints the running applications to `System.out`. Issues like #670 could benefit from being able to use the info from `FluoList`. One possible solution would be to move the functionality to another method like `public T list()` where `T` was some type that had the relevant information for listing applications. Then `execute()` could call `list()` and print the information to `System.out`. The web app mentioned in #670 could just call `list()` directly. The other commands would each have to be looked at individually.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
