keith-turner commented on a change in pull request #304: Add optional support
for Azure ADLS Gen2
URL: https://github.com/apache/fluo-muchos/pull/304#discussion_r363437648
##########
File path: ansible/roles/hadoop-ha/templates/core-site.xml
##########
@@ -38,4 +38,34 @@
<name>ha.zookeeper.quorum</name>
<value>{{ zookeeper_connect }}</value>
</property>
+{% if use_adlsg2 == True %}
+ <property>
Review comment:
If this section is the same as the HA core site, I wonder if it would be
possible to place it in a separate file and include it in both core site files.
This would ease maintenance going forward. Maybe something like
```
{% if use_adlsg2 == True %}
{% include "../../hadoop/adslg2-core-site-snippet.xml" %}
{% endif %}
```
I am not sure if this will work or if this the best way to do this. I was
just looking around at some ansible docs and saw `include`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
