keith-turner commented on issue #1083: [WIP] POC for Command module with 
centralized Command Pattern logic
URL: https://github.com/apache/fluo/pull/1083#issuecomment-572225575
 
 
   > I also want to squash all the commits once it's fully complete.
   
   That is something  usually do after review is complete and its approved.  I 
usually use the Squash and Merge button on github (there is a drop down arrow 
beside the Create a Merge Commit button) when there are no merge conflcts.  Be 
careful with the Squash and merge button though.  In the past it failed for me 
and when it did a retry button showed up.  When I pressed retry it merged all 
of my commits instead of doing squash and merge.  This has happened to me 
twice, so if I see the it in the future I am not going to retry.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to