keith-turner commented on a change in pull request #306: Implement terminate
and wipe actions for Azure clusters
URL: https://github.com/apache/fluo-muchos/pull/306#discussion_r369062918
##########
File path: lib/muchos/existing.py
##########
@@ -241,6 +241,10 @@ def perform(self, action):
elif action == 'cancel_shutdown':
print("Cancelling automatic shutdown of {0}
cluster".format(self.config.cluster_name))
self.execute_playbook(action + ".yml")
+ # In case of Azure, also check and if necessary wipe the storage
accounts
+ # It is necessary to do this after the common kill and wipe to
ensure that processes are all killed prior to this
+ if action == 'wipe' and self.config.get("general",
"cluster_type") == 'azure':
Review comment:
> Kindly please test wipe for EC2
Not sure I would have time to do that in the short term, not sure if anyone
else could. Looking at the diffs, it seems `wipe.yml` is called in the same
way before and after this change. So it seems likely that EC2 will work the
same as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
