ctubbsii commented on a change in pull request #315: Add conditions for Azure
specific tasks
URL: https://github.com/apache/fluo-muchos/pull/315#discussion_r372167100
##########
File path: ansible/roles/accumulo/templates/accumulo.properties
##########
@@ -43,8 +43,8 @@ tserver.server.threads.minimum=64
## The maximum size for each write-ahead log
tserver.walog.max.size=512M
-{% if use_adlsg2 == True %}
+{% if cluster_type == 'azure' and use_adlsg2 == True %}
general.volume.chooser=org.apache.accumulo.server.fs.PreferredVolumeChooser
general.custom.volume.preferred.default={{ instance_volumes_preferred }}
general.custom.volume.preferred.logger={{ hdfs_root }}/accumulo
-{% endif %}
+{% endif %}
Review comment:
This change unnecessarily deletes the end-of-line marker. It's not a huge
deal, but it's generally good practice to terminate every line with a
line-ending sequence (this project uses Unix style line endings), rather than
rely on the EOF to substitute for EOL. This is something to look out for when
submitting patches produced by a badly-behaving text editor. See
https://stackoverflow.com/a/5813359/196405 for more discussion about this as it
pertains to 'unified diff'-style patches, git, C standards, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
