karthick-rn commented on a change in pull request #327: Configure Job history 
server
URL: https://github.com/apache/fluo-muchos/pull/327#discussion_r387980543
 
 

 ##########
 File path: ansible/roles/hadoop/tasks/start-jhs.yml
 ##########
 @@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+- name: Check if JobHistoryServer is running
+  shell: jps | grep "JobHistoryServer" | grep -v grep
 
 Review comment:
   @ctubbsii you're right! Actually the `grep -v grep` part is not required. 
I'll remove from this play and also from the `start-zookeeper.yml` in the new 
commit. Thanks!
   
   @keith-turner, Currently, `jps` command shows the information from the JVM. 
Even if the /tmp directory was cleared we are still safe as the tool doesn't 
read from the PID files. I have also tested this manually and it works.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to