ZoukeNN commented on issue #1084: Condense fluo.sh URL: https://github.com/apache/fluo/issues/1084#issuecomment-596200784 Hi @jkosh44 , Im new to this project, Before I start to refactor the script, I would like to explain how I would refactor to make sure I am not missing anything. The last case statement starts at line no - 129 , Inside this case body there are lot calls to $JAVA org.apache.fluo.command.FluoProgram with different arguments like - $JAVA org.apache.fluo.command.FluoProgram $1 - $JAVA org.apache.fluo.command.FluoProgram $1 -h - $JAVA org.apache.fluo.command.FluoProgram "$@" so on... My idea is create a function which accepts arguments for running Java.. Here are a list of arguments 1. Java Class Name 2. List of arguments to Java program By doing this, We can make the script more reusable. Please let me know if I am on the right track? Are there any important points I'm missing?. If I am on the right track . I will start working on refactoring the code. Best Regards, Bhuvan.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
