ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r396122631
########## File path: ansible/roles/accumulo/tasks/start-tserver.yml ########## @@ -0,0 +1,33 @@ +# +### Licensed to the Apache Software Foundation (ASF) under one or more +### contributor license agreements. See the NOTICE file distributed with +### this work for additional information regarding copyright ownership. +### The ASF licenses this file to You under the Apache License, Version 2.0 +### (the "License"); you may not use this file except in compliance with +### the License. You may obtain a copy of the License at +### +### http://www.apache.org/licenses/LICENSE-2.0 +### +### Unless required by applicable law or agreed to in writing, software +### distributed under the License is distributed on an "AS IS" BASIS, +### WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +### See the License for the specific language governing permissions and +### limitations under the License. +### +## +- name: install accumulo tserver systemd unit file + template: + src: roles/accumulo/templates/tserver.j2 + dest: "/etc/systemd/system/accumulo_tserver_{{ item }}.service" Review comment: Rather than use custom naming like this, it would be better to leverage systemd's built-in templating: https://fedoramagazine.org/systemd-template-unit-files/ Using a filename like `/etc/systemd/system/accumulo_tserver@{{ item }}.service` to symlink to a single file for all tservers would match systemd conventions a bit better. Even without the symlink, using the `@argument` naming convention will be more familiar to systemd users. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
