ctubbsii commented on a change in pull request #361:
URL: https://github.com/apache/fluo-muchos/pull/361#discussion_r461755039
##########
File path: conf/muchos.props.example
##########
@@ -278,10 +278,11 @@ yarn_nm_mem_mb=16384
# Where:
# Hostname = Must be unique. Will be used for hostname in EC2 or should
match hostname on your own cluster
# Service = Service to run on node (possible values: zookeeper, namenode,
resourcemanager, accumulomaster, client, swarmmanager,
-# mesosmaster, worker, fluo, metrics, spark). The following
services are required: namenode, resourcemanager,
+# mesosmaster, worker, fluo, metrics, spark, elkserver). The
following services are required: namenode, resourcemanager,
# accumulomaster, zookeeper & worker
# If cluster_type=azure, the list of nodes below is auto-generated by the
launch action e.g. "muchos launch --cluster accumuloclstr"
# For the 'azure' cluster type, it is perfectly normal if the auto-generated
list of node names is not sequential
+# For viewing logging and statistics with Kibana, the elkserver service must
be added to a leader node.
Review comment:
I think this mention of elkserver depends on PR #338, doesn't it?
##########
File path: conf/muchos.props.example
##########
@@ -278,10 +278,11 @@ yarn_nm_mem_mb=16384
# Where:
# Hostname = Must be unique. Will be used for hostname in EC2 or should
match hostname on your own cluster
# Service = Service to run on node (possible values: zookeeper, namenode,
resourcemanager, accumulomaster, client, swarmmanager,
-# mesosmaster, worker, fluo, metrics, spark). The following
services are required: namenode, resourcemanager,
+# mesosmaster, worker, fluo, metrics, spark, elkserver). The
following services are required: namenode, resourcemanager,
Review comment:
I think this mention of elkserver depends on PR #338, doesn't it?
##########
File path: README.md
##########
@@ -121,6 +124,7 @@ error when you try to launch your cluster. By default, the
`aws_ami` property is
You will need to changes this value if a newer image has been released or if
you are running in different region
than `us-east-1`.
+
Review comment:
This can be a new sub-section, to differentiate it from the new
"Configuring the AMI" sub-section above:
```suggestion
### Launching the cluster
```
##########
File path: README.md
##########
@@ -113,6 +114,8 @@ their public keys to a file named `keys` in your `conf/`
directory. During the
cluster, this file will be appended on each node to the
`~/.ssh/authorized_keys` file for the user
set by the `cluster.username` property.
+####Configuring the AMI
Review comment:
This doesn't render in GitHub-flavored Markdown. It should be:
```suggestion
### Configuring the AMI
```
##########
File path: conf/muchos.props.example
##########
@@ -278,10 +278,11 @@ yarn_nm_mem_mb=16384
# Where:
# Hostname = Must be unique. Will be used for hostname in EC2 or should
match hostname on your own cluster
# Service = Service to run on node (possible values: zookeeper, namenode,
resourcemanager, accumulomaster, client, swarmmanager,
-# mesosmaster, worker, fluo, metrics, spark). The following
services are required: namenode, resourcemanager,
+# mesosmaster, worker, fluo, metrics, spark, elkserver). The
following services are required: namenode, resourcemanager,
Review comment:
```suggestion
# mesosmaster, worker, fluo, metrics, spark). The following
services are required: namenode, resourcemanager,
```
##########
File path: conf/muchos.props.example
##########
@@ -278,10 +278,11 @@ yarn_nm_mem_mb=16384
# Where:
# Hostname = Must be unique. Will be used for hostname in EC2 or should
match hostname on your own cluster
# Service = Service to run on node (possible values: zookeeper, namenode,
resourcemanager, accumulomaster, client, swarmmanager,
-# mesosmaster, worker, fluo, metrics, spark). The following
services are required: namenode, resourcemanager,
+# mesosmaster, worker, fluo, metrics, spark, elkserver). The
following services are required: namenode, resourcemanager,
# accumulomaster, zookeeper & worker
# If cluster_type=azure, the list of nodes below is auto-generated by the
launch action e.g. "muchos launch --cluster accumuloclstr"
# For the 'azure' cluster type, it is perfectly normal if the auto-generated
list of node names is not sequential
+# For viewing logging and statistics with Kibana, the elkserver service must
be added to a leader node.
Review comment:
```suggestion
```
##########
File path: README.md
##########
@@ -74,6 +75,14 @@ sudo yum install azure-cli-2.0.69-1.el7.x86_64.rpm
When running Muchos under Ubuntu 18.04, checkout these
[tips](docs/azure-ubuntu-1804.md).
+You might also need to configure the `aws_ami` property in [muchos.props].
Muchos by default uses a free
+CentOS 7 image that is hosted in the AWS marketplace but managed by the
+CentOS organization. If you have never used this image in EC2 before, you will
need to go to the
+[CentOS 7 product page][centos7] to accept the software terms. If this is not
done, you will get an
+error when you try to launch your cluster. By default, the `aws_ami` property
is set to an AMI in `us-east-1`.
+You will need to changes this value if a newer image has been released or if
you are running in different region
+than `us-east-1`.
+
Review comment:
> To add to this, the default ami in mucho.props.example should probably
be updated to the most recent ami. It has been at its current version for a
while but it is still different than the default one given in our props file.
Can you create a subsequent PR after this to do that? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
