keith-turner commented on a change in pull request #254:
URL: https://github.com/apache/fluo-uno/pull/254#discussion_r474199567
##########
File path: bin/impl/install.sh
##########
@@ -15,6 +15,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+# shellcheck source=bin/impl/util.sh
Review comment:
What is the purpose of this comment? does it help shellcheck find the
file being sourced?
##########
File path: README.md
##########
@@ -188,17 +188,19 @@ applications or follow the instructions starting at the
[Configure a Fluo applic
section of the Fluo install instructions. These instructions will guide you
through the process of
configuring, initializing, and starting your application.
-[fluo]: http://fluo.apache.org/
-[accumulo]: http://accumulo.apache.org/
-[zookeeper]: http://zookeeper.apache.org/
-[hadoop]: http://hadoop.apache.org/
-[mirrors]: http://www.apache.org/dyn/closer.cgi
-[Webindex]: https://github.com/apache/fluo-examples/tree/main/webindex
+[Accumulo Proxy]: https://github.com/apache/accumulo-proxy
+[Muchos]: https://github.com/apache/fluo-muchos
[Phrasecount]: https://github.com/apache/fluo-examples/tree/main/phrasecount
+[Webindex]: https://github.com/apache/fluo-examples/tree/main/webindex
Review comment:
Seems like you sorted these. Curious how you did that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
