arvindshmicrosoft commented on a change in pull request #338:
URL: https://github.com/apache/fluo-muchos/pull/338#discussion_r489127446
##########
File path: ansible/roles/logstash/templates/logstash-simple.conf
##########
@@ -0,0 +1,55 @@
+input {
Review comment:
@plainolneesh could you please clarify if and how this file is used? I
don't seem to see it being referenced from any Ansible tasks, so it would not
be getting deployed to the actual nodes.
- If it is unused, we should delete it from the code base
- If it is used and intended to be deployed to the nodes, you will need a
`template` task for deploying these within
`ansible/roles/logstash/tasks/main.yml`
##########
File path: lib/muchos/ec2.py
##########
@@ -322,8 +323,8 @@ def terminate(self):
if path.isfile(self.config.hosts_path):
os.remove(self.config.hosts_path)
print("Removed hosts file at ", self.config.hosts_path)
- else:
- print("Aborted termination")
+ else:
Review comment:
@plainolneesh you need to address this - I agree with @keith-turner that
this change looks out of place and should be restored to what it was. If we are
both missing a point, please clarify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
