ctubbsii commented on a change in pull request #257:
URL: https://github.com/apache/fluo-uno/pull/257#discussion_r496173173



##########
File path: conf/uno.conf
##########
@@ -32,10 +32,12 @@ export DOWNLOADS=$UNO_HOME/downloads
 # Tarball file names
 export ACCUMULO_TARBALL=accumulo-$ACCUMULO_VERSION-bin.tar.gz
 export HADOOP_TARBALL=hadoop-"$HADOOP_VERSION".tar.gz
-export ZOOKEEPER_TARBALL=apache-zookeeper-"$ZOOKEEPER_VERSION"-bin.tar.gz
 export FLUO_TARBALL=fluo-$FLUO_VERSION-bin.tar.gz
 export FLUO_YARN_TARBALL=fluo-yarn-$FLUO_YARN_VERSION-bin.tar.gz
-
+export ZOOKEEPER_TARBALL=apache-zookeeper-"$ZOOKEEPER_VERSION"-bin.tar.gz
+if [[ "${ZOOKEEPER_VERSION}" = 3.[01234].* ]]; then

Review comment:
       ```suggestion
   if [[ $ZOOKEEPER_VERSION =~ ^3[.][01234].*$ ]]; then
   ```

##########
File path: conf/uno.conf
##########
@@ -118,6 +120,9 @@ export INSTALL=$UNO_HOME/install
 export DATA_DIR=$INSTALL/data
 # Home directories
 export ZOOKEEPER_HOME=$INSTALL/apache-zookeeper-$ZOOKEEPER_VERSION-bin
+if [[ "${ZOOKEEPER_VERSION}" = 3.[01234].* ]]; then

Review comment:
       ```suggestion
   if [[ $ZOOKEEPER_VERSION =~ ^3[.][01234].*$ ]]; then
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to