ctubbsii commented on a change in pull request #374: URL: https://github.com/apache/fluo-muchos/pull/374#discussion_r496995295
########## File path: .github/workflows/ci.yaml ########## @@ -0,0 +1,48 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# This workflow will build a Java project with Maven +# See also: +# https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven Review comment: Not Java, but another link to GitHub Actions docs might be useful instead. ########## File path: CONTRIBUTING.md ########## @@ -37,7 +37,7 @@ If you are modifying any of the Python code in this project, please use [Black]( black lib --line-length 79 ``` -The [CI](https://github.com/apache/fluo-muchos/tree/main/.travis.yml) for this project runs tools to detect common coding issues with Python and Ansible files. Rather than wait for the CI to flag any issues with your work, please run the [cibuild](https://github.com/apache/fluo-muchos/tree/main/scripts/cibuild.sh) script on your dev machine, which in turn runs the following tools: +The [CI](./.github/workflows/ci.yaml) for this project runs tools to detect common coding issues with Python and Ansible files. Rather than wait for the CI to flag any issues with your work, please run the [cibuild](https://github.com/apache/fluo-muchos/tree/main/scripts/cibuild.sh) script on your dev machine, which in turn runs the following tools: Review comment: I'm not sure all the views where this file is shown, but it might be better to use an absolute path, rather than relative to this file, in case it is shown in views other than the code tree browser. ########## File path: .github/workflows/ci.yaml ########## @@ -0,0 +1,48 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# This workflow will build a Java project with Maven +# See also: +# https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven + +name: CI + +on: + push: + branches: [ '*' ] + pull_request: + branches: [ '*' ] + +jobs: + build: + name: ${{ matrix.os }} + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-18.04, macOS-latest, ubuntu-20.04] Review comment: Do we need both Ubuntus? I would guess `ubuntu-latest` is sufficient, but am fine with both if you think both are useful. ########## File path: README.md ########## @@ -375,8 +375,8 @@ Muchos is powered by the following projects: [boto]: http://boto.cloudhackers.com/en/latest/ [boto3]: https://github.com/boto/boto3 [Ansible]: https://www.ansible.com/ -[ti]: https://travis-ci.org/apache/fluo-muchos.svg?branch=main -[tl]: https://travis-ci.org/apache/fluo-muchos +[ci]: ./workflows/CI/badge.svg +[ga]: ./.github/workflows/ci.yaml Review comment: ```suggestion [ci]: https://github.com/apache/fluo-muchos/workflows/CI/badge.svg [ga]: https://github.com/apache/fluo-muchos/actions ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
