keith-turner commented on issue #153:
URL: https://github.com/apache/fluo-recipes/issues/153#issuecomment-705829895
In cfc86ba4c1faf20da78f8a0fc149c737aca407c7 I think I introduced code that
does not work w/ Java 8. I suspect this is failing because java 8 is being
used by Travis to build. I just successfully ran mvn verify locally w/ Java
11. The changes in #154 will use Java 11 to build, so that may fix this.
However, probably need to make make Java 11 the minimum in the pom. I tried
making the following change in the pom.xml locally
```diff
diff --git a/pom.xml b/pom.xml
index 0c604f1..638270b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -56,8 +56,8 @@
<findbugs.skip>true</findbugs.skip>
<fluo.version>2.0.0-SNAPSHOT</fluo.version>
<hadoop.version>3.1.0</hadoop.version>
- <maven.compiler.source>1.8</maven.compiler.source>
- <maven.compiler.target>1.8</maven.compiler.target>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>11</maven.compiler.target>
<releaseProfiles>fluo-recipes-release</releaseProfiles>
<spark.version>2.4.6</spark.version>
<zookeeper.version>3.4.8</zookeeper.version>
```
When I ran with these changes I saw the following error.
```
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Fluo Recipes Parent 1.3.0-SNAPSHOT:
[INFO]
[INFO] Apache Fluo Recipes Parent ......................... SUCCESS [ 3.791
s]
[INFO] Apache Fluo Recipes Core ........................... FAILURE [ 2.628
s]
[INFO] Apache Fluo Recipes for Apache Accumulo ............ SKIPPED
[INFO] Apache Fluo Recipes using Kryo ..................... SKIPPED
[INFO] Apache Fluo Recipes for Testing .................... SKIPPED
[INFO] Apache Fluo Recipes for Apache Spark ............... SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 6.586 s
[INFO] Finished at: 2020-10-08T17:17:14-04:00
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.gaul:modernizer-maven-plugin:1.5.0:modernizer (modernizer) on project
fluo-recipes-core: Execution modernizer of goal
org.gaul:modernizer-maven-plugin:1.5.0:modernizer failed.:
IllegalArgumentException -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR] mvn <args> -rf :fluo-recipes-core
```
May need to update the modernizer plugin version for Java 11, @ctubbsii
would you happen to know?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
