arvindshmicrosoft commented on a change in pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379#discussion_r509495227
##########
File path: ansible/roles/grafana/handlers/main.yml
##########
@@ -21,11 +21,11 @@
method: POST
body: "{{ item }}"
body_format: json
- status_code: 200,500
+ status_code: 200,500,409
Review comment:
Curious - why is this needed? HTTP 409 seems to be something to do with
conflicts; it would be good to have an understanding of why you added this.
##########
File path: ansible/roles/influxdb/defaults/main.yml
##########
@@ -15,5 +15,5 @@
# limitations under the License.
#
-influxdb_rpm: influxdb-0.9.4.2-1.x86_64.rpm
-influxdb_checksum:
"sha256:9a2b6cfdf70e0050a46d07cc0f4135a7538eaac1a3c1745d860d454179f771fb"
+influxdb_rpm: influxdb-1.8.3.x86_64.rpm
+influxdb_checksum:
"sha256:74c606e2da6d33b193bc6224afb552b09567c7e1a31fee4e51ff48550f59a7cc"
Review comment:
Do they have SHA-512 hashes published? If so, we should use those.
##########
File path: ansible/roles/grafana/files/grafana-default.ini
##########
@@ -0,0 +1,816 @@
+##################### Grafana Configuration Example #####################
Review comment:
Can we eliminate any "reference-only" files like this one
`grafana-default.ini` - it seems to be unused by any actual task?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
