arvindshmicrosoft commented on a change in pull request #420: URL: https://github.com/apache/fluo-muchos/pull/420#discussion_r770756754
########## File path: ansible/roles/azure/files/cloud-init.yml ########## @@ -0,0 +1,23 @@ +#cloud-config +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# +# NOTE: do not modify the first line in this file - it is a mandatory +# header to designate the contents as a cloud-init configuration +# +# Upgrade the instance on first boot: +package_upgrade: true Review comment: @ctubbsii this is to unblock deployments on Azure. As it stands right now, launching a cluster on Azure, with either CentOS 7.5 or 7.9 (and presumably any versions in between) fails because the ca-certificates package on the OS is outdated and consequently the Ansible `get_url` fails. In the previous PRs, the legitimate concern raised by you was that the upgrade packages step would apply to all cluster types. Also, at the time it seemed that bumping up the image to 7.9 for Azure, would solve the problem, but unfortunately, that issue was not really resolved. This PR is conditional to Azure cluster launches and is a must-have, as there are no other more recent updated CentOS 7.x images on Azure. Building a custom patched image and using it for Muchos is time-consuming and not everyone may know how to do that, either. There is no 'mischievous' intent here - this fix is scoped to address the specific problem for Azure based deployments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
