ctubbsii commented on pull request #429:
URL: https://github.com/apache/fluo-muchos/pull/429#issuecomment-1011464207


   > @ctubbsii - how would you like to proceed with this? The only question in 
my mind is whether (or not) to change the default AMI for EC2.
   
   My intent was to support Fedora more easily, and to show how similar Fedora 
and other distros in the same "distro-family" are to the EL7 distros that 
already work out of the box that we've been using. I was pleasantly surprised 
to find that EL8 distros were already supported by conditional logic in our 
ansible playbooks, and aside from the need to use `epel-release` yum repo for 
that, EL8 distros seems identical to Fedora, which means Fedora hasn't diverged 
too much from when EL8 was forked from it.
   
   At a minimum, I'd like to merge the conditional logic that I added in the 
ansible/ directory to better support Fedora. I'd also like to merge the test 
changes so we're not so tightly coupled to current example config values, but 
don't lose any test coverage.
   
   I was hoping to defer to the community consensus on whether to change the 
example config. If the other changes are acceptable, but we want to move that 
out into a separate PR for further consideration, I can do that. I'll await 
community consensus on that. I'd be just as happy using an Alma, Rocky, or 
CentOS 8 Stream AMI by default.
   
   (Note: I also changed the default filesystem format from ext3 to ext4 in 
this PR, but that was just because I don't see a reason to use the older 
generation of ext when the newer one is supported. It's not a Fedora-specific 
change. I didn't test it with CentOS 7, though I'm pretty sure CentOS 7 
supports ext4 just fine.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to