keith-turner commented on code in PR #1122:
URL: https://github.com/apache/fluo/pull/1122#discussion_r1014625935
##########
pom.xml:
##########
@@ -308,6 +313,11 @@
<artifactId>hadoop-client-runtime</artifactId>
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
Review Comment:
Thanks @ctubbsii I didnt see that, but I was also on unstable ground when it
came to understanding whats going on with Maven here. Your comment helped me
improve my understanding. Are the following stmts correct? Just want to make
sure I really understand whats happening.
1. The accumulo maven plugin needs an accumulo version set (in the plugins
dep section) because the plugin will directly call accumulo code to launch
miniaccumulo. When the plugin directly calls miniaccumulo apis it needs to use
the 2.1.0 version and not the 2.0.0 version that the plugin was built with.
2. The plugin launches mini using the classpath of the project (not the
plugings classpath).
If the above is correct, then reason num 2 is why setting the thrift version
as a plugin dep did not work for me.
Yeah there is definitely something goofy going on with logging. When I
first tried to build the hadoop text class could could not be instantiated
because of some logging class not being found. Bumping the hadoop and zk
versions up to something later made things work, not sure why. I suspect its
all revolves around log4j1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
