Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo/pull/767#discussion_r79409232
  
    --- Diff: 
modules/core/src/main/java/org/apache/fluo/core/metrics/MetricsReporterImpl.java
 ---
    @@ -0,0 +1,65 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
    + * agreements. See the NOTICE file distributed with this work for 
additional information regarding
    + * copyright ownership. The ASF licenses this file to you under the Apache 
License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the 
License. You may obtain a
    + * copy of the License at
    + * 
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing, software 
distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
    + * or implied. See the License for the specific language governing 
permissions and limitations under
    + * the License.
    + */
    +
    +package org.apache.fluo.core.metrics;
    +
    +import com.codahale.metrics.MetricRegistry;
    +import org.apache.fluo.api.config.FluoConfiguration;
    +import org.apache.fluo.api.metrics.Counter;
    +import org.apache.fluo.api.metrics.Histogram;
    +import org.apache.fluo.api.metrics.Meter;
    +import org.apache.fluo.api.metrics.MetricsReporter;
    +import org.apache.fluo.api.metrics.Timer;
    +import org.apache.fluo.core.metrics.types.CounterImpl;
    +import org.apache.fluo.core.metrics.types.HistogramImpl;
    +import org.apache.fluo.core.metrics.types.MeterImpl;
    +import org.apache.fluo.core.metrics.types.TimerImpl;
    +
    +/**
    + * Implementation of {@link MetricsReporter} that reports application 
metrics using Fluo metrics
    + */
    +public class MetricsReporterImpl implements MetricsReporter {
    +
    +  private final FluoConfiguration config;
    +  private final MetricRegistry registry;
    +  private final String prefix;
    +
    +  public MetricsReporterImpl(FluoConfiguration config, MetricRegistry 
registry,
    +      String metricsReporterID) {
    +    this.config = config;
    +    this.registry = registry;
    +    this.prefix = MetricNames.APPLICATION_PREFIX + "." + metricsReporterID 
+ ".";
    +  }
    +
    +  @Override
    +  public Counter counter(String metricName) {
    --- End diff --
    
    These calls should probably have a not null check and after that check the 
string does not contain `.`.  I Think in this case if the metricName were null 
it would successfully concatenate with the string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to