keith-turner commented on a change in pull request #883: Fixes #842 Support
multiple ways for running Fluo applications
URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r130768152
##########
File path:
modules/core/src/main/java/org/apache/fluo/core/impl/Environment.java
##########
@@ -125,19 +124,10 @@ private void readZookeeperConfig() {
observers = ObserverUtil.load(curator);
- ByteArrayInputStream bais =
- new
ByteArrayInputStream(curator.getData().forPath(ZookeeperPath.CONFIG_SHARED));
- Properties sharedProps = new Properties();
- sharedProps.load(bais);
-
- FluoConfiguration tmpConfig = new FluoConfiguration();
- for (String prop : sharedProps.stringPropertyNames()) {
- config.setProperty(prop, sharedProps.getProperty(prop));
- tmpConfig.setProperty(prop, sharedProps.getProperty(prop));
- }
+ config = FluoAdminImpl.mergeZookeeperConfig(config);
Review comment:
could curator be passed here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
